[Networkmanager] Question about new param in libnm-core

[Beniamino Galvani]

On Thu, May 25, 2023 at 07:27:22AM +0000, Wardzala, Dominik wrote:
> Hello NetworkManager team,
>    I need to add new parameter called acs to libnm-core, which is required in our project, because of custom firmware.
> 
> I will do this locally without modifying main path.
> I use version 1.36.6 as a base.
> This new param should be similar to
> 
> #define NM_SETTING_WIRELESS_HIDDEN "hidden"
> 
> from src/libnm-core-public/nm-setting-wireless.h.
> I also added getter, PROP, and define it in src/libnm-core-impl/nm-setting-wireless.c using
> 
> _nm_setting_property_define_direct_boolean
> 
> The problem I faced is when I tried to modify it or read it with nmcli c commands.
> Then I got errors:
> 
> (process:17887): nm-CRITICAL **: 09:17:23.837: file src/libnmc-setting/nm-meta-setting-desc.c: line 738 (<dropped>): should not be reached
> (process:17887): nm-CRITICAL **: 09:17:23.837: file src/libnmc-setting/nm-meta-setting-desc.c: line 47 (<dropped>): should not be reached
> (process:17887): GLib-GObject-WARNING **: 09:17:23.837: g_object_get_is_valid_property: object class 'NMSettingWireless' has no property named 'acs'
> 
> I suppose that something is still missing on nmcli side, but I don't have idea what it might be.
> Could you advise how to add any new param to be changeable by nmcli?
> 
> I provide diff file with my patch. If any other information should be provided I do this.

Hi, I don't see anything wrong with your patch. Please make sure that
nmcli is rebuilt to properly include the changes in libnm-core.

Beniamino
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/networkmanager/attachments/20230525/03f47cd6/attachment-0001.sig>