[Networkmanager] Question about new param in libnm-core

[Wardzala, Dominik]

Hello NetworkManager team,
   I need to add new parameter called acs to libnm-core, which is required in our project, because of custom firmware.

I will do this locally without modifying main path.
I use version 1.36.6 as a base.
This new param should be similar to

#define NM_SETTING_WIRELESS_HIDDEN "hidden"

from src/libnm-core-public/nm-setting-wireless.h.
I also added getter, PROP, and define it in src/libnm-core-impl/nm-setting-wireless.c using

_nm_setting_property_define_direct_boolean

The problem I faced is when I tried to modify it or read it with nmcli c commands.
Then I got errors:

(process:17887): nm-CRITICAL **: 09:17:23.837: file src/libnmc-setting/nm-meta-setting-desc.c: line 738 (<dropped>): should not be reached
(process:17887): nm-CRITICAL **: 09:17:23.837: file src/libnmc-setting/nm-meta-setting-desc.c: line 47 (<dropped>): should not be reached
(process:17887): GLib-GObject-WARNING **: 09:17:23.837: g_object_get_is_valid_property: object class 'NMSettingWireless' has no property named 'acs'

I suppose that something is still missing on nmcli side, but I don't have idea what it might be.
Could you advise how to add any new param to be changeable by nmcli?

I provide diff file with my patch. If any other information should be provided I do this.

Thanks for any hints and your supports.

Best Regards,
Dominik


Dominik Wardzala
Software Engineer
Harman Connected Services Poland Sp. z o.o.

Ogrodowa 8
91-062 Lodz, Poland
Mobile:
Email: dominik.wardzala3 at harman.com<http://dominik.wardzala3@harman.com>
Web: www.harman.com<http://www.harman.com/>
[Harman_Email_Template]

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/networkmanager/attachments/20230525/41d619ae/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: acs.diff
Type: text/x-patch
Size: 10623 bytes
Desc: acs.diff
URL: <https://lists.freedesktop.org/archives/networkmanager/attachments/20230525/41d619ae/attachment.bin>