[Nice] Fw: patch: nice_agent_get_selected_socket

[Bryce Allen]

Forgot to CC the list. I'll work on adding a test too, as Rohan
suggested.

-Bryce


Begin forwarded message:

Date: Thu, 14 Nov 2013 16:35:25 -0600
From: Bryce Allen <ballen at ci.uchicago.edu>
To: Olivier Crête <olivier.crete at collabora.com>
Subject: Re: [Nice] patch: nice_agent_get_selected_socket


On Thu, 14 Nov 2013 17:10:58 -0500
Olivier Crête <olivier.crete at collabora.com> wrote:
> I also think returning a GSocket is the right level.
> 
> I think you're not the first one to want this. One question, why do
> you just not return a GSocket * or NULL instead of having a separate
> boolean and GSocket** ?
> 
I was trying to be consistent with nice_agent_get_selected_pair, but
I guess it's using out variables because it needs to return two
things. Attached is a modified version that returns GSocket *.

Thanks,
Bryce
-------------- next part --------------
A non-text attachment was scrubbed...
Name: get-selected-socket2.diff
Type: text/x-patch
Size: 3071 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nice/attachments/20131116/5c125340/attachment.bin>