[libnice] [Nice] Peer reflexive and NICE_COMPATIBILITY_RFC5245

[Youness Alaoui]

When using RFC5245, then the username/password is set with
nice_agent_set_remote_credentials, and all the candidates use the same
user/pass. What you changed is a function to find which remote candidate
the peer used by using the username/password to detect it because for
google and MSN compatibilities, they use a different username/password per
candidate.
So I would say your patch is wrong. There were some changes to how
local/remote candidates are detected in the latest git master, maybe you
can try that and explain what your issue is if it persists.

Thanks,
Youness.



On Mon, Jan 20, 2014 at 3:21 AM, Yannick LE COENT <yannick.lecoent at nexcom.fr
> wrote:

> Hi,
>
>
>
> I use libnice-0.1.4  with licode MCU and ICE connectivity check does not
> seem to work with peer reflexive candidates.
>
> The MCU uses the NICE_COMPATIBILITY_RFC5245 mode.
>
>
>
> The debug indicates that the peer reflexive is checked with an empty
> username and password (not the ones from the remote candidate).
>
>
>
> I added the following in conncheck.c (line # 2826) and now it works.
>
>
>
>       agent->compatibility == NICE_COMPATIBILITY_RFC5245 ||
>
>
>
> Is it the right patch ?
>
>
>
> Thanks for any help,
>
> Yannick
>
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/nice/attachments/20140617/b75b4532/attachment.html>