[Nouveau] [PATCH] drm/nouveau/gr/gf100: Log info message when loading external firmware

[Dan Moulding]

Any comments? I also think for developers, it's good to be able to see from someone's dmesg output whether or not external firmware was loaded. Unless there is some other way to do that without this log message?

-- Dan

On Sep 17, 2016, at 02:04 AM, Dan Moulding <dmoulding at me.com> wrote:

In previous versions, it used to log an info message when loading
external GR firmware. But that info message was (inadvertently?)
removed in commit 18cd5bc. This just adds it back. It's nice for users
to be able to confirm whether external firmware was loaded or not.

Signed-off-by: Dan Moulding <dmoulding at me.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index ae9ab5b..0ed56ff 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
@@ -1805,6 +1805,7 @@ gf100_gr_new_(const struct gf100_gr_func *func, struct nvkm_device *device,
     return ret;

     if (gr->firmware) {
+          nvkm_info(&gr->base.engine.subdev, "using external firmware\n");
               if (gf100_gr_ctor_fw(gr, "fecs_inst", &gr->fuc409c) ||
            gf100_gr_ctor_fw(gr, "fecs_data", &gr->fuc409d) ||
            gf100_gr_ctor_fw(gr, "gpccs_inst", &gr->fuc41ac) ||
-- 
2.7.3

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20160929/90c6cb87/attachment.html>