[Openchrome-users] Per ID driver defaults

[Jon Nettleton]

On Thu, 2006-12-07 at 10:43 +0100, Xavier Bachelot wrote: 
> Jon Nettleton wrote:
> > I was looking at a bunch of my machines' xorg.conf files.  I notice that
> > many of them have similar options like DisableIRQ and EnableAGPDMA
> > enabled.  I realize this isn't true for every chipset, but I wonder if
> > it makes sense to map the most common options settings for the different
> > PCI id's and use those as the defaults that can be over-ridden in
> > xorg.conf?  
> > 
> > I would be willing to work on the code if people think this is worth
> > trying.
> > 
> > Jon
> > 
> I had built such a list sometime ago, for CLE266, KM400, KM400A, K8M800, 
> and VN700. According to this list, EnableAGPDMA can be enable anywhere, 
> while DisableIRQ is only needed for KM400 and K8M800, not sure about 
> KM400A, but I have one at home so I will be able to check.
> 
> Regards,
> Xavier

I was going to grab people on IRC, but decided this was a better forum.
Basically I have added a function VIASetupDefaultOptions that does just
that, initializes the all the default options for the _VIA structure and
then sets per chipset defaults if we all agree they are the most
compatible.  

To do this I had to first change UseVBEModes to pVia->useVBEModes and
add it to the _VIA structure.  This is reflected in the
add_useVBEModes_VIA_struct.patch. ;-)  I have that split out for quick
review.

The second patch reflects the rest of the work.  Unfortunately the
chipset detection was done at the very end of PreInit, which would make
the per chipset options a little hard.  I have moved that up.  It works
fine, but I would like some input as to why that code shouldn't be
moved.  I have also only commented out where the default option settings
were setup in PreInit, because I think there will be some discussion
what defaults should be moved to VIASetupDefaultOptions.  Currently I
just moved options that belonged to the _VIA structure.  Do we want to
move more or less options in/out of that function?  Do we want to only
have Booleans?  All things that are open for discussion.

Thanks for the input guys.

Jon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_per_chipset_default_options.patch
Type: text/x-patch
Size: 12959 bytes
Desc: not available
Url : http://wiki.openchrome.org/pipermail/openchrome-users/attachments/20061208/dc3acba5/add_per_chipset_default_options.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_useVBEModes_VIA_struct.patch
Type: text/x-patch
Size: 1747 bytes
Desc: not available
Url : http://wiki.openchrome.org/pipermail/openchrome-users/attachments/20061208/dc3acba5/add_useVBEModes_VIA_struct.bin