[Openchrome-users] new dri options

[Boris Dušek]

Hi Benno,

On Tuesday 03 October 2006 13:06, you wrote:
> Hi all,
>
> Boris Du?ek wrote:
> > [...] so then I will send the patch (I discovered some error, it
> > needs to be corrected
>
> You meant the driQueryOptioni() that had to be a driQueryOptionb(),
> Boris?  That error was found by Jon and is fixed in attached patch.
> Or was it something else?

First sorry I forgot about this again.

Since I don't have the source code at my hand, I will use terms (like 
identifiers) that are not exact or correct, but you will be able to guess 
perfectly their meaning (I hope).

No, it was another error, in my patch, I was removing some "#if 0" statements 
that were disabling the SSE memcpy, thinking that everywhere the vc->memcpy 
function is used (or something like that, I mean the function that was 
previously configured by #ifdef HAVE_SSE and now is by driQuery...).
But then I discovered that somewhere in the code that I enabled by commenting 
out the "#ifdef 0", there were hardcoded references to memcpy_sse. And I did 
not have the time to take a look if the functions have at their disposal the 
vc structure (ViaContext or something like that) that has the pointer to the 
actual and configured memcpy function to use. Maybe just replacing the 
memcpy_sse with vc->memcpy suffices, but I simply did not finish this.

So I am sending one of my last patches, but use it just for reference where 
can be the place with the mentioned "#if 0", not for applying, because I have 
a feeling that the last patches are more experimental (like they even don't 
have to compile/work correctly). The "#if 0" which I mean is at the very end 
of the patch (via_tris.c), unfortunately the patch was generated by cvs diff, 
so there are lots of changes in intel/radeon stuff in the patch, just ignore 
them.

>
> The patch adds all four new options to common/xmlpool/t_options.h,
> so they can be translated.  The alternate screen option doesn't
> look very useful, though, as it only seems to black out the
> glxgears window.  Page flipping and SSE copying don't have any
> noticeable effect, so they need a more detailed description.
>
> The second patch moves the debug_control struct from via_context.c
> to via_screen.c, to make the debugging block in there work.
>
> Benno

Hope this helps,

Boris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: via-xmlconfig-2006-05-17.patch.gz
Type: application/x-gzip
Size: 5302 bytes
Desc: not available
Url : http://wiki.openchrome.org/pipermail/openchrome-users/attachments/20061003/a9ef0b5d/via-xmlconfig-2006-05-17.patch.bin