[Piglit] [PATCH 01/15] arb_direct_state_access: Testing glCreateBuffers.

[Laura Ekstrand]

Bump.  The driver functionality is upstreamed, so I'm planning on pushing
these tests next Monday.

Martin:  There's another, separate test for CreateBuffers that I sent out a
couple of weeks ago that addresses your concerns here.

On Wed, Feb 18, 2015 at 6:45 AM, Martin Peres <martin.peres at linux.intel.com>
wrote:

> Please check that a buffer returned by glCreateBuffers will return true
> when passed as a parameter of IsBuffer();
> Please also check that negative n return INVALID_VALUE.
>
> For these reasons, I decided to create the create-*.c tests for all the
> create functions. One could argue that they
> could all be folded into the same file now that I think of it...
>
>
> On 23/01/15 21:03, Laura Ekstrand wrote:
>
>> ---
>>   tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 2 +-
>>   tests/spec/arb_direct_state_access/texture-buffer-range.c      | 2 +-
>>   tests/spec/arb_direct_state_access/texture-buffer.c            | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
>> b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
>> index 9546af5..0d72df4 100644
>> --- a/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
>> +++ b/tests/spec/arb_direct_state_access/getcompressedtextureimage.c
>> @@ -224,7 +224,7 @@ getTexImage(bool doPBO, GLenum target, GLubyte *data,
>>         /* Setup the PBO or data array to read into from
>>          * glGetCompressedTextureImage */
>>         if (doPBO) {
>> -               glGenBuffers(1, &packPBO);
>> +               glCreateBuffers(1, &packPBO);
>>                 glBindBuffer(GL_PIXEL_PACK_BUFFER, packPBO);
>>                 /* Make the buffer big enough to hold uncompressed data.
>> */
>>                 glBufferData(GL_PIXEL_PACK_BUFFER, layer_size *
>> num_faces *
>> diff --git a/tests/spec/arb_direct_state_access/texture-buffer-range.c
>> b/tests/spec/arb_direct_state_access/texture-buffer-range.c
>> index 859000e..49c835a 100644
>> --- a/tests/spec/arb_direct_state_access/texture-buffer-range.c
>> +++ b/tests/spec/arb_direct_state_access/texture-buffer-range.c
>> @@ -135,7 +135,7 @@ piglit_init(int argc, char **argv) {
>>         glGenVertexArrays(1, &vao);
>>         glBindVertexArray(vao);
>>   -     glGenBuffers(1, &tbo);
>> +       glCreateBuffers(1, &tbo);
>>         glBindBuffer(GL_ARRAY_BUFFER, tbo);
>>         glBufferData(GL_ARRAY_BUFFER, sizeof(data), data, GL_STATIC_DRAW);
>>   diff --git a/tests/spec/arb_direct_state_access/texture-buffer.c
>> b/tests/spec/arb_direct_state_access/texture-buffer.c
>> index 1246071..47f694f 100644
>> --- a/tests/spec/arb_direct_state_access/texture-buffer.c
>> +++ b/tests/spec/arb_direct_state_access/texture-buffer.c
>> @@ -70,7 +70,7 @@ piglit_display(void)
>>         prog = piglit_build_simple_program(vs_source, fs_source);
>>         glUseProgram(prog);
>>   -     glGenBuffers(1, &bo);
>> +       glCreateBuffers(1, &bo);
>>         glBindBuffer(GL_TEXTURE_BUFFER, bo);
>>         glBufferData(GL_TEXTURE_BUFFER, sizeof(g_rgba8), g_rgba8,
>>                      GL_STREAM_DRAW);
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20150318/f0b71a24/attachment.html>