[Piglit] [PATCH] fbo-depth-array: Fix reporting the piglit_result

[Marek Olšák]

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
On Nov 30, 2015 1:19 PM, "Neil Roberts" <neil at linux.intel.com> wrote:

> test_once was ignoring the return value of draw_and_test_layer so the
> test would report a pass even if it failed.
>
> Reported-by: Marek Olšák <maraeo at gmail.com>
> ---
>
> Oops, sorry about that. Thanks for reporting it.
>  tests/fbo/fbo-depth-array.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/fbo/fbo-depth-array.c b/tests/fbo/fbo-depth-array.c
> index b0acd5e..45c8b3b 100644
> --- a/tests/fbo/fbo-depth-array.c
> +++ b/tests/fbo/fbo-depth-array.c
> @@ -446,7 +446,7 @@ test_once(void)
>                         x = 1 + (layer % 3) * (width + 1);
>                         y = 1 + (layer / 3) * (height + 1);
>                 }
> -               draw_and_test_layer(x, y, layer);
> +               pass = draw_and_test_layer(x, y, layer) && pass;
>
>                 if (piglit_use_fbo && !test_single_size && layer <
> layers-1) {
>                         glClearColor(0.2, 0.1, 0.1, 1.0);
> --
> 1.9.3
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20151130/6569c3db/attachment.html>