[Piglit] [PATCH] arb_program_interface_query: fix array of arrays case

[andrey simiklit]

Hi,

> On 21/08/18 21:38, asimiklit.work at gmail.com wrote:
>
> From: Andrii Simiklit <andrii.simiklit at globallogic.com> <andrii.simiklit at globallogic.com>
>
> According to spec:
>    "For an active variable declared as an array of an aggregate data type
>     (structures or arrays), a separate entry will be generated for each
>     active array element, unless noted immediately below ..."
> Mesa should return valid index for 'vs_input2[1][0]' cases.
>
> I believe the key word above is "active" yes they are separate but if I'm
> remembering this problem correctly they are not all active.
>
> I believe this is a Mesa bug not a piglit bug, it was just tricky to fix and always a low priority.
>
> See: https://bugs.freedesktop.org/show_bug.cgi?id=92822#c7
>
> Thanks for your fast reply.
Yes you are right I missed it in my investigation.

Regards,
Andrii.

On Tue, Aug 21, 2018 at 3:46 PM, Timothy Arceri <tarceri at itsqueeze.com>
wrote:

> On 21/08/18 21:38, asimiklit.work at gmail.com wrote:
>
> From: Andrii Simiklit <andrii.simiklit at globallogic.com> <andrii.simiklit at globallogic.com>
>
> According to spec:
>    "For an active variable declared as an array of an aggregate data type
>     (structures or arrays), a separate entry will be generated for each
>     active array element, unless noted immediately below ..."
> Mesa should return valid index for 'vs_input2[1][0]' cases.
>
> I believe the key word above is "active" yes they are separate but if I'm
> remembering this problem correctly they are not all active.
>
> I believe this is a Mesa bug not a piglit bug, it was just tricky to fix and always a low priority.
>
> See: https://bugs.freedesktop.org/show_bug.cgi?id=92822#c7
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107639
> Signed-off-by: Andrii Simiklit <andrii.simiklit at globallogic.com> <andrii.simiklit at globallogic.com>
> ---
>  tests/spec/arb_program_interface_query/getprogramresourceindex.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_program_interface_query/getprogramresourceindex.c b/tests/spec/arb_program_interface_query/getprogramresourceindex.c
> index 16b38e2..92d9a90 100755
> --- a/tests/spec/arb_program_interface_query/getprogramresourceindex.c
> +++ b/tests/spec/arb_program_interface_query/getprogramresourceindex.c
> @@ -167,8 +167,9 @@ static const struct subtest_index_t index_subtests[] = {
>  	{   vs_aofa,              GL_PROGRAM_INPUT,          "vs_input2", false, -1, GL_NO_ERROR },
>  	{   vs_aofa,              GL_PROGRAM_INPUT,       "vs_input2[0]",  true, -1, GL_NO_ERROR },
>  	{   vs_aofa,              GL_PROGRAM_INPUT,    "vs_input2[0][0]",  true, -1, GL_NO_ERROR },
> -	{   vs_aofa,              GL_PROGRAM_INPUT,    "vs_input2[1][0]", false, -1, GL_NO_ERROR },
> +	{   vs_aofa,              GL_PROGRAM_INPUT,    "vs_input2[1][0]",  true, -1, GL_NO_ERROR },
>  	{   vs_aofa,              GL_PROGRAM_INPUT,    "vs_input2[0][1]", false, -1, GL_NO_ERROR },
> +	{   vs_aofa,              GL_PROGRAM_INPUT,    "vs_input2[1][1]", false, -1, GL_NO_ERROR },
>  	{    vs_sub,          GL_VERTEX_SUBROUTINE,                "vss",  true, -1, GL_NO_ERROR },
>  	{    vs_sub,          GL_VERTEX_SUBROUTINE,               "vss2",  true, -1, GL_NO_ERROR },
>  	{ vs_subidx,          GL_VERTEX_SUBROUTINE,            "vss_idx",  true,  5, GL_NO_ERROR },
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/piglit/attachments/20180821/766020b0/attachment-0001.html>