[Pixman] [Patch] Gradient dithering into pixman (Try 2)
marc at jeanmougin.fr
Sat Apr 28 09:21:19 UTC 2018
Can I get any input if my second patch follows "the right approach"? Are
there any astylerc or clang_format to check that my code complies with
code style ?
On 04/19/2018 08:41 PM, Marc Jeanmougin wrote:
> Could anyone help me from here? If there is still a fundamental
> problem with the patch, I'll be happy to rework it (or if there is
> anything more needed in it)
> From what I gathered, pixman is without maintainer, so I'm not sure
> either how to proceed or who to contact...
> On 04/08/2018 10:46 PM, Marc Jeanmougin wrote:
>> Hi, I'm back :)
>> I tried to implement the proposed changes :
>> * the gradient walker now deals with argb_t (floats) and not uint32_t
>> * all gradients are WIDE because of the above change
>> * WIDE formats (using argb_t) can be dithered on write_back call
>> depending on the "dither" property of the image (set with
>> * The dithering is still random. I could try to implement other ones if
>> it's really needed for the patch to be accepted
>> Thanks for any feedback, please do tell if there are any more changes
>> needed for the patch to be accepted.
>> Pixman mailing list
>> Pixman at lists.freedesktop.org
> Pixman mailing list
> Pixman at lists.freedesktop.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pixman