[Poppler-bugs] [Bug 59933] Cleanup patch for bug 50992

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59933

--- Comment #4 from Adam Reichold <adamreichold at myopera.com> ---
(In reply to comment #3)
> Created attachment 75446 [details] [review]
> cleanup code
> 
> Here now the complete cleanup patch. Even if successfully regtested, please
> have again a deeper look into the code.

Just a short remark on the "Lock" class: I think you could merge the two
constructors using a default argument, e.g.

Lock(GooMutex *mutexA, LockMode modeA = DoLock) : mutex(mutexA) { mode = modeA;
if (mode == DoLock) gLockMutex(mutex); }

and comparing it with Qt's QMutexLocker, explicit "lock" and "unlock" methods
might be useful if one wants to break RAII locally.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130224/606bc54b/attachment.html>