[Poppler-bugs] [Bug 59933] Cleanup patch for bug 50992

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59933

--- Comment #5 from Thomas Freitag <Thomas.Freitag at alfa.de> ---
(In reply to comment #4)
> (In reply to comment #3)
> > Created attachment 75446 [details] [review] [review]
> > cleanup code
> > 
> > Here now the complete cleanup patch. Even if successfully regtested, please
> > have again a deeper look into the code.
> 
> Just a short remark on the "Lock" class: I think you could merge the two
> constructors using a default argument, e.g.
> 
> Lock(GooMutex *mutexA, LockMode modeA = DoLock) : mutex(mutexA) { mode =
> modeA; if (mode == DoLock) gLockMutex(mutex); }
> 
> and comparing it with Qt's QMutexLocker, explicit "lock" and "unlock"
> methods might be useful if one wants to break RAII locally.

Can You take over and implement it based on my patch or do it in an additional
step if Albert agrees? Reason for my question: I agree to Your comment, but I'm
working such a long time and too much hours on this feature that I'm getting
too tired to spend any unnecessary additional hour :-(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130224/8f72493a/attachment-0001.html>