[Poppler-bugs] [Bug 59933] Cleanup patch for bug 50992

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59933

--- Comment #7 from Albert Astals Cid <tsdgeos at terra.es> ---
Created attachment 75854
  --> https://bugs.freedesktop.org/attachment.cgi?id=75854&action=edit
Patch on top of Thomas'

I'm attaching a patch that i want to commit on top of Thomas' it has a few
changes:
 * Remove the namespace (we don't use much/any namespaces in poppler core)
 * Rename the class and defines from lock to locker since lock and be either
the action "to lock" or the "thing that locks", with locker it is more clear (i
think) that is "the thing" than "the action"
 * Make Annot::decRefCnt use gLockMutex since we the object itself is being
deleted in the if and not sure the locker would be happy with that
 * change the getNumPages() param to be DoNotLockMutex since previously it was
a gFalse (i guess Thomas made a c&p typo here)
 * Have only one constructor like Adam suggested.

Comments?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130303/0fd2c162/attachment.html>