[Poppler-bugs] [Bug 59933] Cleanup patch for bug 50992

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=59933

--- Comment #8 from Adam Reichold <adamreichold at myopera.com> ---
Hello Albert,

(In reply to comment #7)
> Created attachment 75854 [details] [review]
> Patch on top of Thomas'
> 
> I'm attaching a patch that i want to commit on top of Thomas' it has a few
> changes:
>  * Remove the namespace (we don't use much/any namespaces in poppler core)

Actually, I had a few stray crashes in qpdfview because of pure virtual methods
being called through naming collisions with Poppler internal (e.g. defining an
::Outline class), but of course, namespacing the Locker won't help that. :-)

>  * Rename the class and defines from lock to locker since lock and be either
> the action "to lock" or the "thing that locks", with locker it is more clear
> (i think) that is "the thing" than "the action"

I agree, it is clearer.

>  * Make Annot::decRefCnt use gLockMutex since we the object itself is being
> deleted in the if and not sure the locker would be happy with that

Makes sense.

>  * change the getNumPages() param to be DoNotLockMutex since previously it
> was a gFalse (i guess Thomas made a c&p typo here)
>  * Have only one constructor like Adam suggested.
> 
> Comments?

Best regards, Adam.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20130303/239d1910/attachment.html>