[Poppler-bugs] [Bug 70981] glib-demo: Add support for simple line annotations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70981

--- Comment #8 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 89307
  --> https://bugs.freedesktop.org/attachment.cgi?id=89307
glib: Add PopplerPoint boxed type

Review of attachment 89307:
-----------------------------------------------------------------

Looks good, but I don't think we should assume a point represents only the
position of an annotation in the page, I think it's generic even if it's only
used by the annotations API at the moment. So, I would move it to poppler-page,
like PopplerRectangle or PopplerColor.

::: glib/poppler-annot.h
@@ +178,5 @@
> + * @x: x coordinate
> + * @y: y coordinate
> + *
> + * A #PopplerPoint is used to describe a location point for an annotation
> + * on a page

s/for an annotation//

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131117/434fb3bc/attachment.html>