[Poppler-bugs] [Bug 70981] glib-demo: Add support for simple line annotations

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=70981

--- Comment #9 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 89308
  --> https://bugs.freedesktop.org/attachment.cgi?id=89308
glib: Add support for simple line annotations

Review of attachment 89308:
-----------------------------------------------------------------

Looks great, I have just a few minor comments

::: glib/poppler-annot.cc
@@ +1495,5 @@
> +/* PopplerAnnotLine */
> +/**
> + * poppler_annot_line_set_vertices:
> + * @poppler_annot: a #PopplerAnnotLine
> + * @start: Coordinates of the starting vertice

a #PopplerPoint ... so that we have a link ot the PopplerPoint documentation
here

@@ +1496,5 @@
> +/**
> + * poppler_annot_line_set_vertices:
> + * @poppler_annot: a #PopplerAnnotLine
> + * @start: Coordinates of the starting vertice
> + * @end: Coordinates of the starting vertice

Ditto.

@@ +1498,5 @@
> + * @poppler_annot: a #PopplerAnnotLine
> + * @start: Coordinates of the starting vertice
> + * @end: Coordinates of the starting vertice
> + *
> + * Set the point the coordinates where the @poppler_annot starts and ends.

the point the coordinates?

@@ +1505,5 @@
> + */
> +void
> +poppler_annot_line_set_vertices (PopplerAnnotLine *poppler_annot,
> +                                 PopplerPoint start,
> +				 PopplerPoint end)

Use pointers for start and end

@@ +1509,5 @@
> +				 PopplerPoint end)
> +{
> +  AnnotLine *annot;
> +
> +  g_return_if_fail (POPPLER_IS_ANNOT_LINE (poppler_annot));

check also here that start and end are both != NULL

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20131117/cfc0165e/attachment-0001.html>