[Poppler-bugs] [Bug 73269] install error callback to redirect errors to the GLib logging framework

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73269

Christian Persch (GNOME) <chpe at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92386|0                           |1
        is obsolete|                            |

--- Comment #7 from Christian Persch (GNOME) <chpe at gnome.org> ---
Created attachment 92409
  --> https://bugs.freedesktop.org/attachment.cgi?id=92409&action=edit
updated patch

(In reply to comment #6)
> > +  g_log (G_LOG_DOMAIN, G_LOG_LEVEL_INFO,
> 
> Shouldn't we use "Poppler" as log domain?

It does; G_LOG_DOMAIN is #define'd to "Poppler" in Makefile.am (INCLUDES).

> > +static void poppler_constructor (void) __attribute__((__constructor__));
> 
> Why do you need this prototype? I think you can annotate the method
> directly, for example:
> 
> static void __attribute__((__constructor__)) poppler_constructor (void)
> {
>   setErrorCallback (error_cb, NULL);
> }

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140119/a05cffd9/attachment-0001.html>