[Poppler-bugs] [Bug 73269] install error callback to redirect errors to the GLib logging framework

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73269

Carlos Garcia Campos <carlosgc at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to comment #7)
> Created attachment 92409 [details] [review]
> updated patch
> 
> (In reply to comment #6)
> > > +  g_log (G_LOG_DOMAIN, G_LOG_LEVEL_INFO,
> > 
> > Shouldn't we use "Poppler" as log domain?
> 
> It does; G_LOG_DOMAIN is #define'd to "Poppler" in Makefile.am (INCLUDES).

Oh, right!

> > > +static void poppler_constructor (void) __attribute__((__constructor__));
> > 
> > Why do you need this prototype? I think you can annotate the method
> > directly, for example:
> > 
> > static void __attribute__((__constructor__)) poppler_constructor (void)
> > {
> >   setErrorCallback (error_cb, NULL);
> > }
> 
> Fixed.

Pushed to git master, thank you very much.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20140121/522d7a40/attachment.html>