[Poppler-bugs] [Bug 92040] [RFC PATCH] Complete support for transition effect durations (they can be fractional)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92040

--- Comment #5 from Carlos Garcia Campos <carlosgc at gnome.org> ---
Comment on attachment 118362
  --> https://bugs.freedesktop.org/attachment.cgi?id=118362
The patch

Review of attachment 118362:
-----------------------------------------------------------------

::: glib/poppler-page.h
@@ +341,5 @@
> +  gdouble duration;
> +  gint angle;
> +  gdouble scale;
> +  gboolean rectangular;
> +};

Thanks for the patch. What does Ex stand for? I don't think we need a new boxed
type for this. I think that as long as we don't change the order of the struct
members, we can append a new one without breaking api/abi. So, I would just add
gdouble duration_float to the existing struct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20151202/92b97b9b/attachment.html>