[Poppler-bugs] [Bug 92040] [RFC PATCH] Complete support for transition effect durations (they can be fractional)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92040

Arseniy Lartsev <arseniy at alumni.chalmers.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118362|0                           |1
        is obsolete|                            |

--- Comment #6 from Arseniy Lartsev <arseniy at alumni.chalmers.se> ---
Created attachment 120275
  --> https://bugs.freedesktop.org/attachment.cgi?id=120275&action=edit
Non-integer transition durations for poppler-glib

(In reply to Carlos Garcia Campos from comment #5)

> Thanks for the patch. What does Ex stand for? I don't think we need a new
> boxed type for this. I think that as long as we don't change the order of
> the struct members, we can append a new one without breaking api/abi. So, I
> would just add gdouble duration_float to the existing struct.

Right, people are not supposed to create instances of the structure by direct
malloc, are they. This is what happens when a KDE user starts hacking on
GObject stuff :) Here's a new patch (I called in duration_real to be consistent
with the already existing counterpart in the Qt wrapper, and also because
"float" might be confusing whet the type is double).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20151202/0a263354/attachment.html>