[Poppler-bugs] [Bug 92040] [RFC PATCH] Complete support for transition effect durations (they can be fractional)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92040

--- Comment #7 from Carlos Garcia Campos <carlosgc at gnome.org> ---
(In reply to Arseniy Lartsev from comment #6)
> Created attachment 120275 [details] [review]
> Non-integer transition durations for poppler-glib
> 
> (In reply to Carlos Garcia Campos from comment #5)
> 
> > Thanks for the patch. What does Ex stand for? I don't think we need a new
> > boxed type for this. I think that as long as we don't change the order of
> > the struct members, we can append a new one without breaking api/abi. So, I
> > would just add gdouble duration_float to the existing struct.
> 
> Right, people are not supposed to create instances of the structure by
> direct malloc, are they.

Right, those are always allocated by poppler. It's unfortunate that those
struct are public, but still.

> This is what happens when a KDE user starts hacking
> on GObject stuff :) 

:-)

> Here's a new patch (I called in duration_real to be
> consistent with the already existing counterpart in the Qt wrapper, and also
> because "float" might be confusing whet the type is double).

OK, sounds good to me. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler-bugs/attachments/20151202/2fb6c10f/attachment-0001.html>