[Poppler-bugs] [Bug 105758] [Patch] Add support for hide action in PDF Forms

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105758

--- Comment #1 from Albert Astals Cid <aacid at kde.org> ---
Thanks and sorry for the delay on reviewing!

I was wondering if to future proof the Qt5 API and its users (the core API can
be changed as much as we want), it would make sense to change
  QString targetName() const;
be
  QVector<QString> targets() const;

And for now we just return one value. This way when we implement cases b/c the
application that uses poppler-qt5 will hopefully magically just work?

Also can you please change the Qt5::LinkHide constructor to be like the
LinkOCGState one, i.e. so that it gets the private passed in, this way it's
clear "normal users" should not create one, and if we need to pass more stuff
to the constructor we don't break ABI or anything since it's still a pointer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180407/3260ba88/attachment.html>