[Poppler-bugs] [Bug 105758] [Patch] Add support for hide action in PDF Forms

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105758

Andre Heinecke <aheinecke at intevation.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #138372|0                           |1
        is obsolete|                            |

--- Comment #2 from Andre Heinecke <aheinecke at intevation.de> ---
Created attachment 138702
  --> https://bugs.freedesktop.org/attachment.cgi?id=138702&action=edit
Patch to add support for the hide action - Updated 1

(In reply to Albert Astals Cid from comment #1)
> Thanks and sorry for the delay on reviewing!

No problem. Thanks for the review :-)

> I was wondering if to future proof the Qt5 API and its users (the core API
> can be changed as much as we want), it would make sense to change
>   QString targetName() const;
> be
>   QVector<QString> targets() const;
> 
> And for now we just return one value. This way when we implement cases b/c
> the application that uses poppler-qt5 will hopefully magically just work?

Good idea. I'll change the okular patch accordingly.

> Also can you please change the Qt5::LinkHide constructor to be like the
> LinkOCGState one, i.e. so that it gets the private passed in, this way it's
> clear "normal users" should not create one, and if we need to pass more
> stuff to the constructor we don't break ABI or anything since it's still a
> pointer.

Changed. I didn't understand why the OCGState used this pattern and oriented
myself on the others ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler-bugs/attachments/20180409/63b4f625/attachment.html>