[poppler] QT4, API documentation

[Albert Astals Cid]

A Dimarts 29 Novembre 2005 21:43, Stefan Kebekus va escriure:
> Hi,
Hi

> I have started to write a bit of documentation, which I attach to this
> mail. Please commit if you like it (the 'Mainpage.dox' goes to the
> qt4/src-directory, the 'doxywizard' stripped the documentation off the
> Doxyfile, but since everything is well-documented in the wizard, I think
> that's ok).
Hmm, i'd like to keep that comments, they don't hurt and maybe someone does 
not want to use the wizard.

QT4 -> Qt4 !!!

> I had another look at the splashRenderToPixmap method, and I have a few
> question about that
>
> * The API looks a bit absurd. Do you think it can still be changed, or do
> we have to maintain binary compatibility?
Not in Qt4 frontend, that's why we have the unstable define ;-)

> If not, I would remove the argument "QPixmap **q", and simply return a 
QPixmap.
Nope, that's not good, returning a QPixmap will make you copy he QPixmap two 
times, that is, one when creating it 
q = new QPixmap(QPixmap::fromImage(*img));
and another when you return it and assign it from the application side
That's what my sometimes good sometimes bad knowledge tells me but i can be 
wrong.

> * I assume that the method can fail in some circumstances. Is failure
> indicated in any way?
Hmmm, can you define fail? It can maybe not render correctly the page beacuse 
poppler has a bug rendering that document, but IIRC it never fails in the 
sense of a "controlled" error.

> * It seems to me that none of the arguments "x, y, w, h" is ever used.
> Shall we use them, or shall we just remove them?
Well, i think we should keep them and try to implement the "sliced" rendering 
Pablo Rodíguez asked in his last mail.

Thanks for the work, but could you please resend the patch with the 

Albert

>
> Best,
>
> Stefan.

		
______________________________________________ 
Renovamos el Correo Yahoo! 
Nuevos servicios, más seguridad 
http://correo.yahoo.es