[poppler] Patch for embedding videos in to the pdf

[srinivas adicherla]

Hi Albert

     Actually I didn't get any warnings about accessing png info structure
variables. I think in some old versions it may occur.
But for safety reason I replaced them with the functions. Please find the
new patch attached with this mail.


Thanks
--
A Srinivas

On Wed, Mar 16, 2011 at 12:30 AM, <poppler-request at lists.freedesktop.org>wrote:

> Send poppler mailing list submissions to
>        poppler at lists.freedesktop.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>        http://lists.freedesktop.org/mailman/listinfo/poppler
> or, via email, send a message with subject or body 'help' to
>        poppler-request at lists.freedesktop.org
>
> You can reach the person managing the list at
>        poppler-owner at lists.freedesktop.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of poppler digest..."
>
>
> Today's Topics:
>
>   1. Re: Patch for embedding videos in to the pdf (Albert Astals Cid)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Mon, 14 Mar 2011 22:12:10 +0000
> From: Albert Astals Cid <aacid at kde.org>
> Subject: Re: [poppler] Patch for embedding videos in to the pdf
> To: poppler at lists.freedesktop.org
> Message-ID: <201103142212.10597.aacid at kde.org>
> Content-Type: Text/Plain;  charset="utf-8"
>
> A Dilluns, 14 de mar? de 2011, Albert Astals Cid va escriure:
> > A Dijous, 10 de mar? de 2011, srinivas adicherla va escriure:
> > > Hi Albert
> > >
> > >             Sorry I forgot to remove xrefA from 'load_from_png'. And I
> > >
> > > check if the
> > > video_name is null iam assigning video_name = video_file
> > >
> > > Thanks
> >
> > Looks good to me now, if noone disagrees i'll commit it to master in the
> > next 24 hours or so.
>
> Actually i disagree :D
>
> Can you please fix these warnings
>
> /home/tsdgeos/devel/poppler/poppler/Annot.cc: In function ?MemStream*
> load_from_png(FILE*, Object*)?:
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4147:17: warning:
> ?png_info_struct::color_type? is deprecated (declared at
> /usr/include/png.h:661)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4147:17: warning:
> ?png_info_struct::color_type? is deprecated (declared at
> /usr/include/png.h:661)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4150:25: warning:
> ?png_info_struct::width? is deprecated (declared at /usr/include/png.h:647)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4150:25: warning:
> ?png_info_struct::width? is deprecated (declared at /usr/include/png.h:647)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4151:26: warning:
> ?png_info_struct::height? is deprecated (declared at
> /usr/include/png.h:648)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4151:26: warning:
> ?png_info_struct::height? is deprecated (declared at
> /usr/include/png.h:648)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4162:47: warning:
> ?png_info_struct::rowbytes? is deprecated (declared at
> /usr/include/png.h:651)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4162:47: warning:
> ?png_info_struct::rowbytes? is deprecated (declared at
> /usr/include/png.h:651)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4167:74: warning:
> ?png_info_struct::rowbytes? is deprecated (declared at
> /usr/include/png.h:651)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4167:74: warning:
> ?png_info_struct::rowbytes? is deprecated (declared at
> /usr/include/png.h:651)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4175:17: warning:
> ?png_info_struct::channels? is deprecated (declared at
> /usr/include/png.h:672)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4175:17: warning:
> ?png_info_struct::channels? is deprecated (declared at
> /usr/include/png.h:672)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4180:62: warning:
> ?png_info_struct::bit_depth? is deprecated (declared at
> /usr/include/png.h:659)
> /home/tsdgeos/devel/poppler/poppler/Annot.cc:4180:62: warning:
> ?png_info_struct::bit_depth? is deprecated (declared at
> /usr/include/png.h:659)
>
> Albert
>
> > Albert
> > _______________________________________________
> > poppler mailing list
> > poppler at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/poppler
>
>
> ------------------------------
>
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/poppler
>
>
> End of poppler Digest, Vol 73, Issue 23
> ***************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110316/ea7b39d6/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: srinivas_video_embedd.patch
Type: text/x-patch
Size: 14880 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/poppler/attachments/20110316/ea7b39d6/attachment-0001.bin>