[poppler] splashModeDeviceN8 in two switch

[William Bader]

As far as I know, the SPLASH_CMYK flag adds support necessary for -level1sep to work dependably without breaking anything else.
Without SPLASH_CMYK, if a PDF has certain types of images and you use -level1sep, parts of poppler think that the image data is cmyk and parts of poppler think that the image data is rgb, and the image in the generated ps is messed up, like on an old style analog television with vertical hold out of sync.
It is not very much additional code, and I never understood why it was a build option instead of always being included.
Maybe like OPI_SUPPORT it was experimental, and the flag should have been permanently enabled after the code was tested.
Regards,
William

________________________________
From: poppler <poppler-bounces at lists.freedesktop.org> on behalf of Adam Reichold <adam.reichold at t-online.de>
Sent: Tuesday, April 23, 2019 12:11 PM
To: poppler at lists.freedesktop.org
Subject: Re: [poppler] splashModeDeviceN8 in two switch

Hello,

thinking about this again with a bit of distance, should we maybe remove
the `SPLASH_CMYK` preprocessor flag entirely? I am assuming the reasons
for having this upstream is to keep the code from bit rotting as
Poppler's internals change? If nobody builds this, then this will not
happen. (CI checks improve things, but it will still be "late" feedback
instead of being part of the initial edit-compile-test cycle. Also, this
will not reach e.g. clusterfuzz which thereby will not verify that code.)

Are there any downsides to removing the conditional compilation? Does
this break code that does not request the CMYK handling explicitly? If
so, could we fix this via the internal API instead of hard-coded it at
compile time?

Best regards,
Adam

Am 22.04.19 um 13:14 schrieb Albert Astals Cid:
> This is mostly for William since AFAIK he's the "only" one using SPLASH_CMYK.
>
> I've tried to enable SPLASH_CMYK on the CI and it's loudly complaining that the splashModeDeviceN8 cases are missing in SplashOutputDev.cc
>
> https://gitlab.freedesktop.org/aacid/poppler/-/jobs/253647
>
> Any suggestion of what the code should be?
>
> Should they just be the same as case splashModeCMYK8: ? The first one looks like it may make sense, but not so sure about the second.
>
> Cheers,
>   Albert
>
>
> _______________________________________________
> poppler mailing list
> poppler at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/poppler
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/poppler/attachments/20190423/f9631ef7/attachment.html>