[Portland] Re: Misc cleanup #2
Kevin Krammer
kevin.krammer at gmx.at
Sun Apr 30 05:19:33 PDT 2006
On Sunday 30 April 2006 03:01, Jeremy White wrote:
> > I had a problem the first time as well, turned out I forgot to ssh-add
> > the SSH key I sent in for my account :)
>
> Doh! I'm in; the email I got was quite misleading, but I still
> should have thought of that.
>
> To be honest, though, I prefer running my patches past other folks,
> so forgive me for posting everything I draw up anyways.
> (I suppose now you can just reply 'looks good, please commit',
> and save yourself some hassle if you like).
I think this is a good practice, I am doing it as well unless it is only about
minor changes.
> Speaking of which, here's another cleanup. This one:
> * Decouples script creation from man page and html page creation
> * Explicitly separates the manpage install and creation
> This allows 'make install' to have dependencies on the scripts,
> thereby preventing dopes like me from neglecting to regenerate scripts.
Looks good to me, although I am not sure why "install" does not just depend
on "all"
Cheers,
Kevin
--
Kevin Krammer <kevin.krammer at gmx.at>
Qt/KDE Developer, Debian User
Moderator: www.mrunix.de (German), www.qtcentre.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/portland/attachments/20060430/c52d5947/attachment.pgp
More information about the Portland
mailing list