[pulseaudio-discuss] [PATCH v3 4/4] Revert "card: Support adding ports dynamically"

Mikel Astiz mikel.astiz.oss at gmail.com
Mon Mar 25 11:13:03 PDT 2013


Hi Tanu,

On Mon, Mar 25, 2013 at 7:51 AM, Tanu Kaskinen <tanuk at iki.fi> wrote:
> On Thu, 2013-03-07 at 11:32 +0100, Mikel Astiz wrote:
>> From: Mikel Astiz <mikel.astiz at bmw-carit.de>
>>
>> This reverts commit a9c3f2fb0fc1a1ee0072aac6425ad7311a2a5888.
>>
>> It has been recently agreed that ports should somehow have some physical
>> meaning, leading to the port merge in module-bluetooth-device.
>>
>> With this assumption in mind, it is very unlikely that a card would
>> add or remove ports dynamically. Therefore, the core can be simplified
>> by removing the support for this.
>>
>> The revert affects the code added to module-card-restore in commit
>> a1a0ad1af209e58c136ac1c884aa5d14672a7144, which can now be partially
>> removed.
>>
>> Conflicts:
>>       src/pulsecore/card.c
>>       src/pulsecore/core.h
>> ---
>>  src/modules/module-card-restore.c | 43 ---------------------------------------
>>  src/pulsecore/card.c              | 19 -----------------
>>  src/pulsecore/card.h              |  1 -
>>  src/pulsecore/core.h              |  1 -
>>  4 files changed, 64 deletions(-)
>
> It was suggested that this patch wouldn't be applied yet. When would be
> the right time?

I don't see Bluetooth making use of this feature, so unless the alsa
modules can benefit from it, which seems unlikely, I'd rather remove
it before the release freeze.

Cheers,
Mikel


More information about the pulseaudio-discuss mailing list