[pulseaudio-discuss] [PATCH v6] filter-apply: Fixed a stream moves to wrong sink or source.

[Georg Chini]

On 21.04.2017 00:38, KimJeongYeon wrote:
>
> 2017. 4. 21. 오전 3:28에 "Georg Chini" <georg at chini.tk 
> <mailto:georg at chini.tk>>님이 작성:
>
>     Still found a few issues, but I think the next version will be final.
>
>
>         +
>         +            trigger_housekeeping(u);
>         +            return PA_HOOK_OK;  /* goto done; */
>
>
>     You forget to free module_name. I would move the "done" label
>     before the
>     "if (done_something)" and do "done_something=true; goto done" here.
>
>
> Sorry. It was my mistake while doing my local merging. 'goto done;' is 
> correct.

Still I would not call trigger_housekeeping() here but instead move the 
"done" label.
But I don't mind if you prefer it otherwise.

>
>
>           static pa_hook_result_t source_output_proplist_cb(pa_core
>         *core, pa_source_output *o, struct userdata *u) {
>               pa_core_assert_ref(core);
>               pa_source_output_assert_ref(o);
>
>
>     Didn't you want to avoid the double move here? Or will that be
>     another patch?
>
>
> I hope submit another patch. It might be regarded as another issue.
>

OK.

> I'll submit patch v7 as soon as possible.
> Thanks for reviewing!
>
> Regards,
> KimJeongYeon


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170421/e17469be/attachment.html>