[pulseaudio-discuss] [PATCH v6] filter-apply: Fixed a stream moves to wrong sink or source.

[KimJeongYeon]

2017-04-21 14:12 GMT+09:00 Georg Chini <georg at chini.tk>:

> On 21.04.2017 00:38, KimJeongYeon wrote:
>
>
> 2017. 4. 21. 오전 3:28에 "Georg Chini" <georg at chini.tk>님이 작성:
>
> Still found a few issues, but I think the next version will be final.
>
> +
>> +            trigger_housekeeping(u);
>> +            return PA_HOOK_OK;  /* goto done; */
>>
>
> You forget to free module_name. I would move the "done" label before the
> "if (done_something)" and do "done_something=true; goto done" here.
>
>
> Sorry. It was my mistake while doing my local merging. 'goto done;' is
> correct.
>
>
> Still I would not call trigger_housekeeping() here but instead move the
> "done" label.
> But I don't mind if you prefer it otherwise.
>
>
Your suggestions are good for me.
I've submitted patch v7 just ago.

Regards,
KimJeongYeon

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20170421/ece4a924/attachment.html>