[pulseaudio-discuss] [pulseaudio-commits] [Git][pulseaudio/pulseaudio][master] i18n: Don't compile with -ffast-math

[Georg Chini]

On 13.07.19 14:03, Georg Chini wrote:
> On 13.07.19 14:00, Georg Chini wrote:
>> On 28.05.19 18:18, Tanu Kaskinen wrote:
>>> GitLab
>>>
>>>
>>>       Tanu Kaskinen pushed to branch master at PulseAudio /
>>>       pulseaudio <https://gitlab.freedesktop.org/pulseaudio/pulseaudio>
>>>
>>>
>>>         Commits:
>>>
>>>   * *fd9e3452
>>>     <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b>*
>>>
>>>     by Felipe Sateler /at 2019-05-28T16:16:49Z/
>>>     i18n: Don't compile with -ffast-math
>>>
>>>     This flag results in calls to (at least) isfinite() and isnan() becoming
>>>     skipped, and a constant false returned. This caused volume-test to fail
>>>     on Debian:https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916504
>>>
>>>     Since PulseAudio deals with negative infinities with volume dB values,
>>>     this is not a problem only in volume-test. We shouldn't use -ffast-math
>>>     at all.
>>>
>>>
>>>         1 changed file:
>>>
>>>   * configure.ac <#87db583be5c13c1f7b3c958b10e03d67b6a2ca06>
>>>
>>>
>>>         Changes:
>>>
>>> # *configure.ac* 
>>> <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b#87db583be5c13c1f7b3c958b10e03d67b6a2ca06> 
>>>
>>> ------------------------------------------------------------------------
>>> ... 	... 	@@ -175,7 +175,7 @@ AX_CHECK_COMPILE_FLAG([-std=gnu11],
>>> 175 	175 	
>>>   [-pedantic -Werror])
>>> 176 	176 	
>>>   
>>> 177 	177 	
>>>   AX_APPEND_COMPILE_FLAGS(
>>> 178 	
>>> 	
>>> -[-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings 
>>> -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op 
>>> -Wsign-compare -Wformat-security -Wmissing-include-dirs 
>>> -Wformat-nonliteral -Wold-style-definition -Wpointer-arith 
>>> -Winit-self -Wdeclaration-after-statement -Wfloat-equal 
>>> -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls 
>>> -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels 
>>> -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter 
>>> -ffast-math -fno-common -fdiagnostics-show-option 
>>> -fdiagnostics-color=auto],
>>>
>>> 	178 	
>>> +[-Wall -W -Wextra -pipe -Wno-long-long -Wno-overlength-strings 
>>> -Wunsafe-loop-optimizations -Wundef -Wformat=2 -Wlogical-op 
>>> -Wsign-compare -Wformat-security -Wmissing-include-dirs 
>>> -Wformat-nonliteral -Wold-style-definition -Wpointer-arith 
>>> -Winit-self -Wdeclaration-after-statement -Wfloat-equal 
>>> -Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls 
>>> -Wmissing-declarations -Wmissing-noreturn -Wshadow -Wendif-labels 
>>> -Wcast-align -Wstrict-aliasing -Wwrite-strings -Wno-unused-parameter 
>>> -fno-common -fdiagnostics-show-option -fdiagnostics-color=auto],
>>> 179 	179 	
>>>   [], [-pedantic -Werror])
>>> 180 	180 	
>>>   
>>> 181 	181 	
>>>   AS_CASE([" $CFLAGS "], [*" -O0 "*], [], [
>>>
>>>
>>> —
>>> View it on GitLab 
>>> <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/commit/fd9e3452e2e2eb298a5d2f58809febf2bf44453b>. 
>>>
>>> You're receiving this email because of your account on 
>>> gitlab.freedesktop.org. If you'd like to receive fewer emails, you 
>>> can adjust your notification settings.
>>>
>>>
>>> _______________________________________________
>>> pulseaudio-commits mailing list
>>> pulseaudio-commits at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-commits
>>
>> This patch breaks the use of the soxr resampler for me.
>> PA crashes under certain conditions. I only tested after
>> applying !120. (Before this patch set, the soxr resampler
>> behaves quite strange anyway).
>>
>> I think PA kicks me out because the real-time limit is
>> exceeded and the limit is exceeded because the resampler
>> is compiled without -ffast-math
>>
Further investigation shows that it does not affect current master.
The problem starts with patch 2 of !120, which changes the soxr
resampler to variable rate. The reason why the crash happens is
totally unclear.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20190715/f45a4f07/attachment-0001.html>