[Spice-devel] [vd-agent-win32 v2 0/2] Add support for WDDM driver

Tue Feb 23 15:41:05 UTC 2016

Hi

El 16/02/16 a las 15:23, Victor Toso escribió:
> Hi Javier,
>
> On Tue, Feb 16, 2016 at 10:50:22AM +0100, Javier Celaya wrote:
>> El 15/02/16 a las 17:01, Javier Celaya escribió:
>>>
>>> El 15/02/16 a las 16:38, Victor Toso escribió:
>>>> Hi,
>>>>
>>>> On Fri, Feb 12, 2016 at 02:41:58PM +0100, Javier Celaya wrote:
>>>>> This patch set adds support for dynamic resolution changes with the WDDM
>>>>> driver on Windows >= 8. It is based on the one sent by Vadim Rozenfeld
>>>>> with some improvements:
>>>>>
>>>>> - It detects both the XDDM driver and the WDDM driver, and uses the
>>>>>    correct API.
>>>>> - It detects if the client is trying to set the same resolution again,
>>>>>    and does nothing. This is the result of the client detecting a primary
>>>>>    surface destruction/construction when the resolution changes, and
>>>>>    asking for a resolution change again. This bug does not happen with
>>>>>    the XDDM driver, so it may be avoidable in some other way.
>>>>> - It uses an alternative method to update the list of display modes,
>>>>>    that results in a nicer effect when changing the resolution. This
>>>>>    method is compatible with the current driver implementation (v0.12),
>>>>>    but for best results we have modified the driver to drop the previous
>>>>>    method and to improve support of hardware pointers. The source can be
>>>>>    found inhttps://github.com/flexvdi/qxl-dod, and precompiled and signed
>>>>>    binaries can be downloaded fromhttp://depot.flexvdi.com/guest-tools/.
>>>> You might be interested in taking a look at Sandy's work recently pushed
>>>> to freedesktop at
>>>> https://cgit.freedesktop.org/~teuf/qxl-wddm-dod/
>>>>
>>>> and thank you for your work on this,
>>>>    toso
>>> Thank you, Victor. I'll see if these patches are in sync with her job.
>> It turns out they are not. In particular, she changed the interface to send
>> a custom resolution to the driver. I'm going to try to coordinate with her,
>> in case she also has a patch set for the vdagent, so do not push these
>> patches upstream yet.
>>
>> Thanks for pointint this out.
> Sure, you are welcome.
>
> Sadly, I don't think Sandy will be working on this anymore. At this
> moment I don't know anyone working on this. The work that she has done
> is the latest that I'm aware of regarding improving qxl-wddm-dod for
> windows 8+.
>
> I consider this a WIP and not yet maintained upstream...
>
> kind regards,
>    toso
I have not heard from Sandy yet. So, I suggest accepting these patches 
as they are now, since they work with the binary WDDM drivers issued by 
Red Hat to date. We will pick Sandy's work into our repository, as long 
as we do not break the current interface between vdagent and WDDM driver.

Best
>>>>> Changes from v1:
>>>>> - New types and classes have been moved from common/vdcommon.h to
>>>>>    vdagent/wddm.h, since they are actually not common to both the vdagent
>>>>>    and the vdservice. The code for those classes is in vdagent/wddm.cpp.
>>>>> - Some improvements as suggested by Frediano Ziglio.
>>>>>
>>>>> Javier Celaya (2):
>>>>>    Detect and use the new WDDM driver
>>>>>    Use CCD API to update the WDDM display modes.
>>>>>
>>>>>   Makefile.am                |   2 +
>>>>>   common/vdcommon.h          |   4 +
>>>>>   vdagent/desktop_layout.cpp |  69 ++++++++++++---
>>>>>   vdagent/wddm.cpp           |  76 +++++++++++++++++
>>>>>   vdagent/wddm.h             | 206 +++++++++++++++++++++++++++++++++++++++++++++
>>>>>   5 files changed, 345 insertions(+), 12 deletions(-)
>>>>>   create mode 100644 vdagent/wddm.cpp
>>>>>   create mode 100644 vdagent/wddm.h
>>>>>
>>>>> -- 
>>>>> 2.4.3
>>>>>
>>>>> _______________________________________________
>>>>> Spice-devel mailing list
>>>>> Spice-devel at lists.freedesktop.org
>>>>> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>>> -- 
>>>
>>>
>>>
>>> <http://flexvdi.com><http://flexvdi.com>
>>>
>>> Javier Celaya
>>>
>>> Software Engineer
>>>
>>> 	
>>>
>>> j <mailto:javier.celaya at flexvdi.com>avier.celaya at flexvdi.com
>>>
>>> +34 876 60 00 73
>>>
>>> @j_celaya
>>>
>> -- 
>>
>>
>>
>> <http://flexvdi.com><http://flexvdi.com>
>>
>> Javier Celaya
>>
>> Software Engineer
>>
>> 	
>>
>> j <mailto:javier.celaya at flexvdi.com>avier.celaya at flexvdi.com
>>
>> +34 876 60 00 73
>>
>> @j_celaya
>>
>>
>>


-- 


<http://flexvdi.com><http://flexvdi.com>

Javier Celaya

Software Engineer

	
j <mailto:javier.celaya at flexvdi.com>avier.celaya at flexvdi.com

+34 876 60 00 73

@j_celaya


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160223/1c7927a8/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo.flexvdi.png
Type: image/png
Size: 17075 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160223/1c7927a8/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mail.png
Type: image/png
Size: 9350 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160223/1c7927a8/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: phone.png
Type: image/png
Size: 15099 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160223/1c7927a8/attachment-0005.png>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160223/1c7927a8/attachment-0003.html>