[systemd-devel] [PATCH 1/2] tmpfiles.d: split files to cope with split packages.

Lennart Poettering lennart at poettering.net
Thu Oct 2 00:16:18 PDT 2014


On Thu, 25.09.14 18:12, Gustavo Sverzut Barbieri (gustavo.barbieri at intel.com) wrote:

> etc.conf was selectively (using m4) using resolved link, now this is
> moved to systemd-resolved.conf file. The etc.conf can be static and
> does not need to be generated anymore.
> 
> systemd.conf was doing all the journal setup, now this is moved to
> systemd-journald.conf file.

journald is not optional. And it won't be. Sorry.

> +z /var/log/journal/remote 2755 root systemd-journal-remote - -
> +z /run/log/journal/remote 2755 root systemd-journal-remote - -

I am not convinced this is really worth it. This line has no effect
anyway if the dir is missing...

> diff --git a/tmpfiles.d/systemd-networkd.conf b/tmpfiles.d/systemd-networkd.conf
> new file mode 100644
> index 0000000..2419755
> --- /dev/null
> +++ b/tmpfiles.d/systemd-networkd.conf
> @@ -0,0 +1,12 @@
> +#  This file is part of systemd.
> +#
> +#  systemd is free software; you can redistribute it and/or modify it
> +#  under the terms of the GNU Lesser General Public License as published by
> +#  the Free Software Foundation; either version 2.1 of the License, or
> +#  (at your option) any later version.
> +
> +# See tmpfiles.d(5) for details
> +
> +d /run/systemd/netif 0755 systemd-network systemd-network -
> +d /run/systemd/netif/links 0755 systemd-network systemd-network -
> +d /run/systemd/netif/leases 0755 systemd-network systemd-network -

I am very much against this. Even if networkd is not used the dirs
should really exist so that libsystemd-network can create an inotify
watch on it without problem. It won't ever see any interfaces in it,
but it will at least not fail. It's really just three dirs in /run,
this costs barely anything.

I am totally not convinced splitting this up is really a good idea...

Lennart

-- 
Lennart Poettering, Red Hat


More information about the systemd-devel mailing list