[virglrenderer-devel] [PATCH v4 3/7] vrend, caps: Add GLES entry for gl_prim_restart

[Erik Faye-Lund]

Looks good :)

Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>


On 01. aug. 2018 12:15, Gert Wollny wrote:
> Use the new cap code path for setting it on GLES
>
> Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> Reviewed-by: Gurchetan Singh <gurchetansingh at chromium.org>
> ---
>   src/vrend_renderer.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/src/vrend_renderer.c b/src/vrend_renderer.c
> index 7471abc..4d807ed 100644
> --- a/src/vrend_renderer.c
> +++ b/src/vrend_renderer.c
> @@ -165,7 +165,7 @@ static const  struct {
>      [feat_framebuffer_fetch] = { UNAVAIL, UNAVAIL, { "GL_EXT_shader_framebuffer_fetch" } },
>      [feat_geometry_shader] = { 32, UNAVAIL, {} },
>      [feat_gl_conditional_render] = { 30, UNAVAIL, {} },
> -   [feat_gl_prim_restart] = { 31, UNAVAIL, {} },
> +   [feat_gl_prim_restart] = { 31, 30, {} },
>      [feat_gles_khr_robustness] = { UNAVAIL, UNAVAIL, { "GL_KHR_robustness" } },
>      [feat_gles31_vertex_attrib_binding] = { 43, 31, { "GL_ARB_vertex_attrib_binding" } },
>      [feat_images] = { 42, 31, { "GL_ARB_shader_image_load_store" } },
> @@ -7854,11 +7854,6 @@ static void vrend_renderer_fill_caps_gles(UNUSED bool fill_capset2, int gles_ver
>      } else {
>         caps->v1.glsl_level = 120;
>      }
> -
> -   if (gles_ver >= 30) {
> -      caps->v1.bset.primitive_restart = 1;
> -   }
> -
>   }
>   
>   static void vrend_renderer_fill_caps_gl(bool fill_capset2, int gl_ver,