[virglrenderer-devel] [PATCH v2 0/2] Fix GLES31 copy_image.non-compressed tests

Gert Wollny gert.wollny at collabora.com
Tue Jul 3 11:21:46 UTC 2018

Dear all, 

The changes compared to the first series are 

 - Drop the patch to change 3-component formats to four componet formats 
   This caused quite a number of piglit regressions. As a result not all of 
   the  copy_image.non-compressed tests are passing, but I think that it is 
   better to get this patch out and then continue to work on the 3-component 
   texture formats. (Mostly figuring out why the piglits fail) 
 - Add a caps for COPY_IMAGE since this is actually an extension to GLES 3.1 
   and might not always be available when the host is not on GLES >= 3.2. 
   This of course needs a sister patch to mesa/virgl. 
 - Honour the render condition when blitting

Regarding the caps flags we might want to consider defining them now so that 
there are no collisions. I've noticed in the experimental branch that (1 << 2)
is already used there for computer shaders, so I skipped to 3 here. 

Changes with piglit compared to master:  
  piglit run gpu -t texture -t gather 

(running the whole of gpu crashes qemu with an assertion on Intel, running it 
on r600 makes less sense, because there are more failures on the host to begin

     blit texture srgb * * *
Apparent regressions: 
    blit texture srgb_to_linear msaa disabled * 
    (this seems to be unstable on master)
Probably unrelated changes (they don't use the glCopyImageSubData code path):

    gl_lumuncance8_snorm (pass -> fail)
    gl_lumuncance16_snorm (fail -> pass)

  multisample-formats 8 gl_ext_texture_srgb (pass -> fail)
    (all others in that group were failing)
  multisample-fast-clear gl_ext_texture_srgb (fail -> pass)

     gl_depth_component_npot (pass -> fail)
     gl_depth_component24 (fail -> pass)
     gl_depth_component24_npot (pass -> fail)
Thanks for reviewing, 

Gert Wollny (2):
  vrend: If available use glCopyImageSubData to execute memcopy like
  virgl-caps: Report support for GL_ARB_copy_image to the guest

 src/virgl_hw.h       |  1 +
 src/vrend_formats.c  | 40 +++++++++++++++++++++++++++++
 src/vrend_renderer.c | 61 +++++++++++++++++++++++++++++++++++++++++---
 src/vrend_renderer.h |  2 ++
 4 files changed, 101 insertions(+), 3 deletions(-)


More information about the virglrenderer-devel mailing list