[virglrenderer-devel] [PATCH 2/2] protect gl{BeginEnd}ConditionalRendering calls

Erik Faye-Lund erik.faye-lund at collabora.com
Wed Jul 18 20:25:37 UTC 2018

On 18. juli 2018 22:20, Po-Hsien Wang wrote:
> Checking fill_caps, which I believe is the point of 
> truth, caps->v1.bset.conditional_render followed the fill_caps_gles 
> and set to false if gles is detected.
> Why we have two different path for filling the have_ and caps?

I just did this because it's the current way things are done. But IMO it 
would be much better if we avoided the repetition. This is error-prone, 
as you just showed :P

More information about the virglrenderer-devel mailing list