[Wayland-bugs] [Bug 762561] Implement primary selection protocol

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762561

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322174|none                        |reviewed
             status|                            |

--- Comment #5 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 322174:

::: gdk/wayland/gdkdevice-wayland.c
@@ +3031,3 @@

+  wayland_seat = GDK_WAYLAND_SEAT (seat);
+  g_hash_table_iter_init (&iter, wayland_seat->touches);

This is not related to this patch, but I fail to see when touches are added to
seat->touches. I do see when they are added to some GdkWaylandDeviceData
though. If seat->touches is always empty we'd regress here anyhow.

::: gdk/wayland/gdkwindow-wayland.c
@@ +1337,3 @@
                                             
parent_impl->display_server.wl_surface,
                                              seat,
+                                            
_gdk_wayland_seat_get_last_implicit_grab_serial (gdk_seat, NULL),

Completely only an opinion, but I think it'd be easier to read to fetch this
value before, and pass it as a variable "grab_serial" or something.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160224/e696f89b/attachment.html>