[Wayland-bugs] [Bug 762561] Implement primary selection protocol

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762561

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322175|none                        |reviewed
             status|                            |

--- Comment #6 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 322175:

::: gdk/wayland/gdkdevice-wayland.c
@@ +931,3 @@
+primary_selection_data_offer (void                                *data,
+                              struct gtk_primary_selection_device
*wp_primary_selection_device,
+                              struct gtk_primary_selection_offer 
*wp_primary_offer)

wp? :P

::: gdk/wayland/gdkselection-wayland.c
@@ +272,3 @@
 {
   selection_buffer_ref (buffer);
+  g_input_stream_read_bytes_async (buffer->stream, READ_BUFFER_SIZE,
G_PRIORITY_DEFAULT,

The changes to this function and selection_buffer_read_cb doesn't look related
to the patch.

@@ +285,2 @@
   info = g_slice_new0 (DataOfferData);
   info->offer = offer;

Should info->offer now be called "offer_data" or something now instead maybe?

@@ +432,3 @@
+static void
+primary_offer_offer (void                               *data,
+                     struct gtk_primary_selection_offer *wp_offer,

wp_ here again and in a few other places.

@@ +879,3 @@
+    {
+      window = wayland_selection->primary_owner;
+      selection = atoms[ATOM_PRIMARY];

Why do you check if the source is a primary selection source here? I wouldn't
expect that wl_data_source.send would ever be called for the primary selection.

@@ +914,3 @@
     atom = atoms[ATOM_DND];
+  else if (source == (gpointer) wayland_selection->primary_source)
+    atom = atoms[ATOM_PRIMARY];

Same here. This is a wl_data_source related function. Why would you check if
its a primary selection source?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20160224/321dd2b6/attachment.html>