[Wayland-bugs] [Bug 771320] [Wayland] Maps widget is displayed at wrong position inside gnome-contacts

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771320

Jonas Ådahl <jadahl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337315|none                        |reviewed
             status|                            |

--- Comment #11 from Jonas Ådahl <jadahl at gmail.com> ---
Review of attachment 337315:

::: gdk/gdkwindow.c
@@ +5989,3 @@
+
+  display = gdk_window_get_display (window);
+  gdk_display_put_event (display, event);

Can be just "gdk_event_put (event);" since you do pretty much what that
function does here.

@@ +6013,3 @@
+        {
+      configure_native_child (child);
+      move_native_children  (child);

Can fix the coding style issue (double space) while at it.

@@ +6102,3 @@
                    window->width, window->height);
     }
+  else

How come this is needed? Shouldn't we still skip moving if the absolute
position didn't change?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20161012/29379b81/attachment-0001.html>