[Wayland-bugs] [Bug 771320] [Wayland] Maps widget is displayed at wrong position inside gnome-contacts

[gtk+ (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771320

Olivier Fourdan <ofourdan at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337315|reviewed                    |none
             status|                            |
 Attachment #337315|0                           |1
        is obsolete|                            |

--- Comment #12 from Olivier Fourdan <ofourdan at redhat.com> ---
Created attachment 337492
  --> https://bugzilla.gnome.org/attachment.cgi?id=337492&action=edit
[PATCH v2] gdkwindow: configure native windows in move_native_children()

(In reply to Jonas Ådahl from comment #11)
> Review of attachment 337315 [details] [review]:
> 
> ::: gdk/gdkwindow.c
> @@ +5989,3 @@
> +
> +  display = gdk_window_get_display (window);
> +  gdk_display_put_event (display, event);
> 
> Can be just "gdk_event_put (event);" since you do pretty much what that
> function does here.

Yeah good idea, and I was leaking the event as well (since it's a copy that
gets added tothe queue,  v2 fixes that.

> @@ +6013,3 @@
> +        {
> +	  configure_native_child (child);
> +	  move_native_children  (child);
> 
> Can fix the coding style issue (double space) while at it.

Coding style is correct here, it's just that it uses a tab (8 char) so it shows
weird in the patch. Anyhow, I replaced it with spaces, but there are tabs in
many other places...

> @@ +6102,3 @@
>  			       window->width, window->height);
>      }
> +  else
> 
> How come this is needed? Shouldn't we still skip moving if the absolute
> position didn't change?

Yes, that's precisely the problem... abs_x/abs_y can be wrong when
transitioning from/to fullscreen/maximized/normal because the shadows and
header bar get added/removed.

You can try by applying the patch and leaving the test as-is, run totem, switch
to maximized back and forth and the clutter-gtk embed widget will be misplaced
(again).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/wayland-bugs/attachments/20161012/b7dc1f4b/attachment.html>