[PATCH 3/3] add resize filter interface support

[Zhao, Halley]

Yeah, I'm wrong here. 


> -----Original Message-----
> From: Pekka Paalanen [mailto:ppaalanen at gmail.com]
> Sent: Friday, June 08, 2012 5:57 PM
> To: Zhao, Halley
> Subject: Re: [PATCH 3/3] add resize filter interface support
> 
> On Fri,  8 Jun 2012 17:33:58 +0800
> Zhao Halley <halley.zhao at intel.com> wrote:
> 
> > ---
> >  src/compositor.c |   57
> +++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >  src/compositor.h |    1 +
> >  2 files changed, 57 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/compositor.c b/src/compositor.c index
> > a768ba6..365cc39 100755
> > --- a/src/compositor.c
> > +++ b/src/compositor.c
> ...
> > @@ -1471,6 +1473,56 @@ surface_set_input_region(struct wl_client
> *client,
> >  	weston_compositor_schedule_repaint(surface->compositor);
> >  }
> >
> > +static void
> > +surface_get_render_attr_caps(struct wl_client *client,
> > +			 struct wl_resource *resource, uint32_t attr_type,
> uint32_t
> > +*attr_values) {
> > +    switch (attr_type) {
> > +    case WL_SURFACE_RESIZE_FILTER_MAG:
> > +    case WL_SURFACE_RESIZE_FILTER_MIN:
> > +        *attr_values = WL_SURFACE_RESIZE_SAMPLING_NEAREST |
> WL_SURFACE_RESIZE_SAMPLING_LINEAR;
> > +        break;
> > +    default:
> > +        *attr_values = 0;
> > +        break;
> > +    }
> > +}
> 
> Hi,
> 
> so... you are passing *an address* through the protocol, from process A
> to process B, and expect that when process B writes into that address,
> process A will see that value? That is wrong in so many ways...
> 
> - pq