Rename text_model and text_model_factory?

Michael Hasselmann michaelh at openismus.com
Sat Feb 2 04:51:02 PST 2013


On Sat, 2013-02-02 at 13:39 +0100, Michael Hasselmann wrote:
> Hi!
> 
> Shouldn't the naming for the complementary interfaces in Weston's
> protocol/text.xml and protocol/input-method.xml be more consistent?
> 
> For instance, there's text_model and text_model_factory interfaces in
> text.xml, but in input-method.xml, the corresponding interfaces are
> called input_method_context (~ text_model) and input_method (~
> text_model_factory).

And another inconsistency I just noticed is how some requests have a
set_* prefix (set_surrounding_text) whereas others have not
(commit_string). Isn't the read/write direction already clear from the
event/request separation? Or should we just always prefix requests with
set_*?

ciao Michael



More information about the wayland-devel mailing list