Rename text_model and text_model_factory?

[Yichao Yu]

On Sat, Feb 2, 2013 at 7:51 AM, Michael Hasselmann
<michaelh at openismus.com> wrote:
> On Sat, 2013-02-02 at 13:39 +0100, Michael Hasselmann wrote:
>> Hi!
>>
>> Shouldn't the naming for the complementary interfaces in Weston's
>> protocol/text.xml and protocol/input-method.xml be more consistent?
>>
>> For instance, there's text_model and text_model_factory interfaces in
>> text.xml, but in input-method.xml, the corresponding interfaces are
>> called input_method_context (~ text_model) and input_method (~
>> text_model_factory).
>
> And another inconsistency I just noticed is how some requests have a
> set_* prefix (set_surrounding_text) whereas others have not
> (commit_string). Isn't the read/write direction already clear from the
> event/request separation? Or should we just always prefix requests with
> set_*?

I think the difference between set_surrounding_text and commit_string
makes some sense since set_surrounding_text is used to set a state
while commit_string is not (more like a action). Not sure if it is
necessary to show this difference in the name though.

>
> ciao Michael
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel