Where should project Weston go?

Daniel Stone daniel at fooishbar.org
Wed Dec 10 16:17:36 PST 2014


On 10 December 2014 at 23:21, Bryce Harrington <bryce at osg.samsung.com>

> One thing I've observed as a contributor and reviewer is that while we
> think of wayland as a "review + gatekeeper" model, many times the
> gatekeeper is the only one to give the review.  I think strengthening on
> the review side might help ease the gatekeeping workload.

Nail -> head.

> An idea I've been kicking around would be to *require* Reviewed-by on
> all patches.  Now, you'd probably think this would *slow* things down,
> but consider this:  If as a patch submitter I know I have to get
> someone's review, then I'm going to be more motivated to give other
> people reviews myself.  I will also find that by making my patches
> easier to review, they'll get a Reviewed-by faster, and thus will land
> faster.
> Of course, we wouldn't want to impose the work of checking Reviewed-by's
> on the gatekeeper; our goal is to simplify their workflow not add more
> to it.  Ideally patchwork would have a mode to "show only reviewed
> patches" and let it do the filtering.  Unfortunately it doesn't have
> that capability (yet?), but we could abuse the State field to track it
> manually.

Right. The gatekeeper merging is really adding an implicit Reviewed-by. So
if we farm out the review task better than we have been (and I know I've
not been doing my fair share), hopefully everyone's lives will improve a

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20141211/0a8b1472/attachment-0001.html>

More information about the wayland-devel mailing list