[Xcb] XCB demo tests compile problems

Bart Massey bart@cs.pdx.edu
Tue, 11 Nov 2003 14:17:13 -0800


In message <20031111221023.GB9141@sharp.ath.cx> you wrote:
> ChangeProperty is a little bit of a pain because properties can have
> just about any type. Arg 8 was a void* because of this, until I tried a
> few days ago to fix a -pedantic warning in XCB. It was using
> sizeof(void), so I changed the type to char*. I guess what I should have
> done was special-case void to not generate the sizeof. That fix is in
> xcb-proto and xcb now, though I haven't tested it against the demos.

That could work.  Wouldn't all problems be solved if the
type was just changed to void*, though?

> >   main.c:207: warning: implicit declaration of function `XCBListIsEmpty'
> 
> That's part of XCB's internal list API that definitely shouldn't be made
> externally visible, because it's not type-safe. There's no public API
> for what main.c is doing, because apps aren't supposed to touch the
> pending replies queue.
> 
> Either that test should be removed from that app; debugging code should
> be added to XCB that reports statistics like this; or main.c should
> #include <X11/XCB/xcbint.h>. Any thoughts?

For now, do the last of these.  We can figure out later
whether we want to do the second instead.  The first seems
like a bad idea.

	Bart