[Xcb] [xsync] attributes of XCBSyncCreateAlarm

[Vincent Torri]

> Indeed, I think these defines from xextproto/sync.h are missing:
>
> /*
> * Flags for Alarm Attributes
> */
> #define XSyncCACounter (1L<<0)
> #define XSyncCAValueType (1L<<1)
> #define XSyncCAValue (1L<<2)
> #define XSyncCATestType (1L<<3)
> #define XSyncCADelta (1L<<4)
> #define XSyncCAEvents (1L<<5)
>
> xcb-proto/src/extensions/sync.xml should be patched like this:
>
>  <enum name="CA">
>    <item name="Counter"><bit>0</bit></item>
>    ... etc. ...
>  </enum>

thank you. Should I file a bug in bugzilla, with a blocker flag ?

> Also, I notice that some of the field types of the structs refer to the 
> enumeration names instead of CARD8/16/32. What size do these end up in 
> the structure definitions? C enums don't actually specify a physical 
> size, so these might be incorrect compared to the wire protocol 
> (xextproto/syncstr.h).
>
> These are a few of the reasons why I wouldn't consider any of the 
> xcb-proto work finished and releasable until we have working test code 
> exercising every bit of it.

Maybe unit tests, using check, gcov and lcov, with good old flags for 
torture compilation in C ANSI and -Werror to be sure that we don't miss 
any warning can help us.

Vincent