[Xcb] [Bug 63158] New: screensaver notify event specification is incorrect

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=63158

          Priority: medium
            Bug ID: 63158
          Assignee: xcb at lists.freedesktop.org
           Summary: screensaver notify event specification is incorrect
        QA Contact: xcb at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: raymond_w at zonnet.nl
          Hardware: Other
            Status: NEW
           Version: unspecified
         Component: Protocol
           Product: XCB

screensaver.xml contains the following specification:

  <event name="Notify" number="0">
    <field type="CARD8" name="code"/>
    <field type="BYTE" name="state"/>    <!-- enum State -->
    <pad bytes="1" />
    <field type="CARD16" name="sequence_number"/>
    <field type="TIMESTAMP" name="time"/>
    <field type="WINDOW" name="root"/>
    <field type="WINDOW" name="window"/>
    <field type="BYTE" name="kind"/>     <!-- enum Kind -->
    <field type="BOOL" name="forced"/>
    <pad bytes="14"/>
  </event>

The sequence_number is added automatically when the struct type is generated
(but then it is called sequence). Similarly, the code field is what xcb calls
response_type. These fields should not be specified in the XML file. I also do
not know why the 1-byte padding is there (added for v1.1 extension update);
maybe to hide symptoms resulting from the duplicate fields?

This was pointed out when screensaver.xml was first submitted [1] but
apparently it has never been fixed; seems like I am the first to actually use
the screensaver extension with xcb.

[1] http://lists.freedesktop.org/archives/xcb/2005-July/000910.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/xcb/attachments/20130405/fafc9e93/attachment.html>