[Kde-hardware-devel] org.freedesktop.PowerManagement

[Matt Chorman]

Hi Richard,

On 3/21/07, Richard Hughes <hughsient at gmail.com> wrote:
>
> On 21/03/07, Alp Toker <alp at atoker.com> wrote:
> > </method>
> > -
> >         <!--
> >   Returns the system AC state, i.e. if we are not running on battery
> >           power.
> >           Note: This method may still return false on AC using a desktop
> > system
> >           if the computer is using backup power from a monitored UPS.
> > -->
> > -
> > <method name="GetAcState">
> > <arg type="b" name="ac_state" direction="out"/>
> > </method>
> >
> > AC (alternating current?) is kind of an implementation detail. I will
> > probably just want to know if the device IsOnExternalPower or something.
> > "AC" means nothing to me as an application developer.
>
> Valid point. What about IsOnBatteryPower?
>
> > <!--
> >   Signals the value of the current brightness has changed.
> > -->
> > <signal name="BacklightBrightnessChanged"/>
> > <!-- Signals the AC state has changed. -->
> > <signal name="AcStateChanged"/>
> > <!-- Signals the low power mode has changed. -->
> > <signal name="LowPowerModeChanged"/>
> > -
> >         <!--
> >   Signals the system state description has changed.
> > -->
> > <signal name="DescriptionChanged"/>
> > <!-- Signals the system icon has changed. -->
> > <signal name="IconChanged"/>
>
>
Same nit-picky stuff for me - It seems to me that if you are going to change
from AC vs. Battery (to abstract the implementation of power), you should
better name the methods and signals to "Internal" or "External" or something
like this - this will cover any type of battery or external power. There are
many data centers that use DC power on rails out to the units so using "AC"
for the external power may not be accurate - i.e. change the signal from
AcStateChanged to ExternalPowerStateChanged, and the method for
IsOnBatteryPower to IsOnExternalPower...

My 2 cents..
--
Matt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freedesktop.org/archives/xdg/attachments/20070322/a124a07e/attachment.html