Regression in 1461b31e40a3e44f6327199d23cf2ab70d8f5176

Eric Anholt eric at anholt.net
Mon May 17 14:27:47 PDT 2010


As of this commit GL has become unreliable on my Intel system:

commit 1461b31e40a3e44f6327199d23cf2ab70d8f5176
Author: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
Date:   Fri May 14 16:25:43 2010 +0300

    dri2: Fix xserver crash if dri2 buffer allocation fails.
    
    If driver fails to allocate memory for dri2 buffer server would crash
    in send_buffers_reply.
    
    Solution is to handle the allocation failure and return BadAlloc to
    client.
    
    Signed-off-by: Pauli Nieminen <ext-pauli.nieminen at nokia.com>
    Reviewed-by: Michel Dänzer <michel at daenzer.net>
    Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>
    Signed-off-by: Keith Packard <keithp at keithp.com>

I'm getting bad rendering and BadDrawable at swapbuffers time frequently
in piglit testcases.  I reverted it and tested that removing it did fix
things.  Grab glsl-fs-exp2, for example, and resize it under metacity,
and you should see the app die in short order.

Xorg.0.log mentions:

[271530.104] (EE) intel(0): [DRI2] DRI2SwapBuffers: drawable has no back or front?

which is not the case in a working server.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg/attachments/20100517/934ba2c8/attachment.pgp>


More information about the xorg mailing list